Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The /v1/internal/ui/services API endpoint responds with only 1 Tag #4222

Closed
johncowen opened this issue Jun 13, 2018 · 1 comment · Fixed by #5579
Closed

The /v1/internal/ui/services API endpoint responds with only 1 Tag #4222

johncowen opened this issue Jun 13, 2018 · 1 comment · Fixed by #5579
Labels
type/enhancement Proposed improvement or new feature
Milestone
Upcoming

Comments

@johncowen
Copy link
Contributor

Please see #4203

The output of:

GET /v1/internal/ui/services

shows:

...
    "Name": "vault",
    "Tags": [
      "standby"
    ],
...

instead of at least:

...
    "Name": "vault",
    "Tags": [
      "standby", "active" ....
    ],
...

Thanks,
@johncowen johncowen mentioned this issue Jun 13, 2018
Closed
@pearkes pearkes modified the milestones: 1.2.0, Upcoming Jun 13, 2018
@johncowen johncowen mentioned this issue Jul 3, 2018
Closed
@pearkes pearkes added the type/enhancement Proposed improvement or new feature label Jul 26, 2018
@pearkes pearkes mentioned this issue Nov 1, 2018
Closed
@ophusky
Copy link

ophusky commented Mar 25, 2019 •
edited
Loading

I have the same problem. I am using consul consul 1.4.4 , and this bug still exists，will it be fixed?
/v1/internal/ui/services result:

{
        "Name": "fooService",
        "Tags": [
            "testtag1",
            "testtag2",
            "testtag3"
        ],
    },

/v1/health/service/fooService result:

"Service": {
            "ID": "fooService",
            "Service": "fooService",
            "Tags": [
                "test",
                "dddd",
                "dev",
                "constact=hz"
            ],
........
"Service": {
            "ID": "fooService",
            "Service": "fooService",
            "Tags": [
                "testtag1",
                "testtag2",
                "testtag3"
            ],

@johncowen johncowen mentioned this issue Mar 25, 2019
Closed
@mkeeler mkeeler mentioned this issue Apr 12, 2019
Merged
35 tasks
mkeeler added a commit that referenced this issue Apr 16, 2019
@mkeeler
Implement data filtering of some endpoints (#5579)
afa1cc9 
Fixes: #4222 

# Data Filtering

This PR will implement filtering for the following endpoints:

## Supported HTTP Endpoints

- `/agent/checks`
- `/agent/services`
- `/catalog/nodes`
- `/catalog/service/:service`
- `/catalog/connect/:service`
- `/catalog/node/:node`
- `/health/node/:node`
- `/health/checks/:service`
- `/health/service/:service`
- `/health/connect/:service`
- `/health/state/:state`
- `/internal/ui/nodes`
- `/internal/ui/services`

More can be added going forward and any endpoint which is used to list some data is a good candidate.

## Usage

When using the HTTP API a `filter` query parameter can be used to pass a filter expression to Consul. Filter Expressions take the general form of:

```
<selector> == <value>
<selector> != <value>
<value> in <selector>
<value> not in <selector>
<selector> contains <value>
<selector> not contains <value>
<selector> is empty
<selector> is not empty
not <other expression>
<expression 1> and <expression 2>
<expression 1> or <expression 2>
```

Normal boolean logic and precedence is supported. All of the actual filtering and evaluation logic is coming from the [go-bexpr](https://github.com/hashicorp/go-bexpr) library

## Other changes

Adding the `Internal.ServiceDump` RPC endpoint. This will allow the UI to filter services better.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
Upcoming
3 participants
@johncowen @pearkes @ophusky