Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blocking query wait time not respected for retrieving leaf certs #4462

Closed
mkeeler opened this issue Jul 27, 2018 · 0 comments
Closed

Blocking query wait time not respected for retrieving leaf certs #4462

mkeeler opened this issue Jul 27, 2018 · 0 comments
Assignees
@mkeeler
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/bug Feature does not function as expected
Milestone
1.4.1

Comments

@mkeeler
Copy link
Member

mkeeler commented Jul 27, 2018

Overview of the Issue

The cache waits the full time (10 minutes for blocking queries). When issuing a blocking query via the HTTP api, the wait time requested via the http "wait" parameter is not respected.

Reproduction Steps

Steps to reproduce this issue, eg:

  1. Create a cluster with connect enabled
  2. Run curl localhost:8500/v1/agent/connect/ca/leaf/test
  3. Run `curl "localhost:8500/v1/agent/connect/ca/leaf/test?wait=3s&index="
  4. Watch it wait 10 minutes instead of 3s to return
@mkeeler mkeeler added type/bug Feature does not function as expected theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Jul 27, 2018
@pearkes pearkes added this to the 1.2.3 milestone Aug 7, 2018
@pearkes pearkes modified the milestones: 1.2.3, 1.3.0 Sep 11, 2018
@mkeeler mkeeler modified the milestones: 1.3.0, 1.4.0 Oct 10, 2018
@banks banks modified the milestones: 1.4.0, Upcoming Oct 15, 2018
@banks banks modified the milestones: Upcoming, 1.4.1 Nov 28, 2018
@mkeeler mkeeler mentioned this issue Jan 7, 2019
Merged
mkeeler added a commit that referenced this issue Jan 8, 2019
@mkeeler
cache: Pass through wait query param to the cache.Get
49b5d9f 
This adds a MaxQueryTime field to the connect ca leaf cache request type and populates it via the wait query param. The cache will then do the right thing and timeout the operation as expected if no new leaf cert is available within that time.

Fixes #4462
@mkeeler mkeeler mentioned this issue Jan 8, 2019
Merged
@mkeeler mkeeler self-assigned this Jan 8, 2019
mkeeler added a commit that referenced this issue Jan 10, 2019
@mkeeler
cache: Pass through wait query param to the cache.Get (#5203)
baa8946 
This adds a MaxQueryTime field to the connect ca leaf cache request type and populates it via the wait query param. The cache will then do the right thing and timeout the operation as expected if no new leaf cert is available within that time.

Fixes #4462 

The reproduction scenario in the original issue now times out appropriately.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkeeler mkeeler

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/bug Feature does not function as expected
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
3 participants
@banks @pearkes @mkeeler