Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notes in check definitions not working? #449

Closed
carlanton opened this issue Oct 31, 2014 · 2 comments · Fixed by #458
Closed

Notes in check definitions not working? #449

carlanton opened this issue Oct 31, 2014 · 2 comments · Fixed by #458
Labels
type/bug Feature does not function as expected

Comments

@carlanton
Copy link
Contributor

Hi!

I'm trying to add notes for my service checks. I've something like this:

In /etc/consul.d I've a file redis.json with the following content:

{
  "service": {
    "name": "redis",
    "tags": ["master"],
    "port": 8000,
    "check": {
      "script": "/usr/local/bin/check_redis.py",
      "interval": "10s",
      "notes" : "A generic service check"
    }
  }
}

The problem is that my notes aren't visible in the GUI or from the API. The notes fields are empty!
Is this supposed to work?

Thanks,
Anton

@carlanton carlanton changed the title Notes in check definition not working? Notes in check definitions not working? Oct 31, 2014
@armon
Copy link
Member

armon commented Nov 3, 2014

I think this is a bug currently, not sure if the agent actually passes the notes through.

@armon armon added the type/bug Feature does not function as expected label Nov 3, 2014
@ryanuber
Copy link
Member

ryanuber commented Nov 7, 2014

@carlanton this should be fixed now in master. Thanks for reporting it!

duckhan pushed a commit to duckhan/consul that referenced this issue Oct 24, 2021
* wait for serf check so consul service exists in the catalog prior to running tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Feature does not function as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants