-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow tags in upstreams #4927
Comments
Have you looked at prepared queries at all? They are supported as an upstream for the built-in proxy and #4969 will add support for them in Envoy. It isn't tag filtering but I believe it may give you what you're looking for based on the description. |
Yeah, I think that could work for my use case and I can look into it. Would be helpful if #1956 was complete though. My specific request is a bit bizarre because I want to be able to send to a specific host. This is for JMX. I imagine I could code it up so each host registers a prepared query on instance creation. Anyways, thanks, I think this is helpful. |
I'm glad, yeah agree #1956 or something like it would improve the experience with prepared queries. One thing I'll suggest for that (going to actually go over there and point it out as well) is that the Consul Terraform Provider supports a prepared_query resource that can potentially provide you with a nice workflow to bootstrap and manage prepared queries. I'm going to close this for now but feel free to comment back or open a new issue if prepared queries are helping with your use-case. |
Feature Description
It would be cool if you could create upstreams and then filter based on tags. Let's say 2 nodes for Service B have two separate tags, it would be nice if in the connect setup for Service A you could have two upstreams with two different local_bind_ports that filter on the two tags for Service B.
I realize this could also be achieved with separate services, but tags seem to already be supported for services so I think the same functionality could be pushed down to the upstreams as well.
Use Case(s)
Just as you might run separate DNS queries for tags within a service, you can also use separate upstreams on the same service but with different tags.
The text was updated successfully, but these errors were encountered: