Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect: implement Prepared Query upstreams for Envoy #4969

Closed
banks opened this issue Nov 16, 2018 · 0 comments
Closed

connect: implement Prepared Query upstreams for Envoy #4969

banks opened this issue Nov 16, 2018 · 0 comments
Assignees
@mkeeler
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/enhancement Proposed improvement or new feature
Milestone
1.4.1

Comments

@banks
Copy link
Member

banks commented Nov 16, 2018

We punted on this to get Envoy support into 1.3.0 and then didn't manage to get to it in time for 1.4.0 either due to other factors.

The reason it wasn't trivial is that prepared queries don't support blocking by their nature (against multiple raft stores, possibly remote etc.). So for now we likely need to poll on some interval. Not quite sure what the appropriate interval is for that as it's potentially expensive to make cross-DC calls every few seconds from potentially thousands of hosts. We could have a conservative one for now and make it configurable perhaps?
@banks banks added type/enhancement Proposed improvement or new feature theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Nov 16, 2018
@pearkes pearkes mentioned this issue Nov 26, 2018
Closed
@pearkes pearkes modified the milestones: Upcoming, 1.4.1 Dec 3, 2018
@banks banks mentioned this issue Jan 9, 2019
Closed
@mkeeler mkeeler mentioned this issue Jan 15, 2019
Merged
mkeeler added a commit that referenced this issue Jan 18, 2019
@mkeeler
Implement prepared query upstreams watching for envoy (#5224)
7e6b3e6 
Fixes #4969 

This implements non-blocking request polling at the cache layer which is currently only used for prepared queries. Additionally this enables the proxycfg manager to poll prepared queries for use in envoy proxy upstreams.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkeeler mkeeler

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/enhancement Proposed improvement or new feature
Projects
None yet
Milestone
1.4.1
Development

No branches or pull requests
3 participants
@banks @pearkes @mkeeler