Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

connect: ensure time.Duration fields retain their human readable forms in the API #6348

Merged
merged 1 commit into from
Aug 19, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Aug 19, 2019

This applies for both config entries and the compiled discovery chain.

Also omit some other config entries fields when empty.

…s in the API

This applies for both config entries and the compiled discovery chain.

Also omit some other config entries fields when empty.
@rboyer rboyer added the theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies label Aug 19, 2019
@rboyer rboyer added this to the 1.6.0-final milestone Aug 19, 2019
@rboyer rboyer requested a review from a team August 19, 2019 20:01
@rboyer rboyer self-assigned this Aug 19, 2019
@rboyer
Copy link
Member Author

rboyer commented Aug 19, 2019

This was mentioned during the PR for #6293

Copy link
Member

@hanshasselberg hanshasselberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@rboyer rboyer merged commit fd1c62e into release/1-6 Aug 19, 2019
@rboyer rboyer deleted the api-cfg-time-duration branch August 19, 2019 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants