docs: add documentation for discovery chains #6293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rboyer
added
type/docs
banks
requested changes
Aug 14, 2019
kaitlincart
reviewed
Aug 19, 2019
kaitlincart
reviewed
Aug 19, 2019
kaitlincart
reviewed
Aug 19, 2019
rboyer
force-pushed
the
discovery-chain-api-docs
branch
from
10147a8 to
84fc8b3
Compare
rboyer
commented
Aug 19, 2019
banks
approved these changes
Aug 20, 2019
kaitlincart
reviewed
Aug 21, 2019
kaitlincart
reviewed
Aug 21, 2019
|
|
||
| The [discovery chain](/docs/internals/discovery-chain.html) for each upstream | ||
| service should be fetched from the | ||
| [`/v1/discovery-chain/:service_id`](/api/discovery-chain.html) API endpoint. |
There was a problem hiding this comment.
Suggested change
| [`/v1/discovery-chain/:service_id`](/api/discovery-chain.html) API endpoint. | |
| [`/v1/discovery-chain/:service_id`](/api/discovery-chain.html) API endpoint to discovery the proxy's configuration. |
kaitlincart
reviewed
Aug 21, 2019
kaitlincart
reviewed
Aug 21, 2019
|
|
||
| # Discovery Chain <sup>beta</sup> | ||
|
|
||
| ~> This topic is part of a [low-level API](/api/discovery-chain.html) |
kaitlincart
approved these changes
Aug 21, 2019
|
I wasn't paying attention and I just merged #6358 into this after it was approved. |
- add service-router example involving gRPC - fix indentation on service-router page by splitting it up - remove reference to removed setting
rboyer
force-pushed
the
discovery-chain-api-docs
branch
from
2974dc0 to
2095749
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6273