docs: add config options that were missing #10617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
added
type/docs
dnephin
force-pushed
the
dnephin/config-add-missing-docs
branch
from
ea334ed to
5581c86
Compare
blake
approved these changes
Jul 14, 2021
|
🍒 If backport labels were added before merging, cherry-picking will start automatically. To retroactively trigger a backport after merging, add backport labels and re-run https://circleci.com/gh/hashicorp/consul/410581. |
|
🍒✅ Cherry pick of commit 0ba5d74 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jul 15, 2021
docs: add config options that were missing
|
🍒✅ Cherry pick of commit 0ba5d74 onto |
hc-github-team-consul-core
pushed a commit
that referenced
this pull request
Jul 15, 2021
docs: add config options that were missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking at the code with @kedevlin we noticed these two config fields were missing from our configuration reference doc. Both of these seem like they would be useful, so this PR adds them to the docs.
#128 added pid_file
#1331 added disable_coordinates