Enable tag drift 02 #1147
Closed
Enable tag drift 02 #1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
July 24, 2015 19:14
…/command/agent TestDecodeConfig
|
@sfncook This should be done on a per-service registration basis, not globally. I think we want to support |
|
What's the status of this pr? Should it be closed since #1187 was merged in? |
|
Yep this one is superseded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a patch in response to Issue #1102 ("Support for "tag drift" between server and client representations"). Essentially: I'm adding the enable_tag_drift config parameter. When this parameter is true then the NodeService.Tags attribute is allowed to be modified by nodes other than the local node. The original value for Tags are allowed to be replaced by other nodes. This is to support a Redis/Sentinel use case in which Sentinels are considered the "owners" of the Redis service's role in context of other Redis instances. (i.e. [master | slave])