Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up some small things in preparation for a 0.6.0 RC1. #1345

Merged
merged 4 commits into from
Oct 26, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions Makefile
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
GOTOOLS = github.com/mitchellh/gox golang.org/x/tools/cmd/stringer
DEPS = $(shell go list -f '{{range .TestImports}}{{.}} {{end}}' ./...)
PACKAGES = $(shell go list ./...)
VETARGS?=-asmdecl -atomic -bool -buildtags -copylocks -methods \
Expand Down Expand Up @@ -26,11 +27,11 @@ cov:

deps:
@echo "--> Installing build dependencies"
@go get -v $(GOTOOLS)
@go get -d -v ./... $(DEPS)

updatedeps: deps
go get -u github.com/mitchellh/gox
go get -u golang.org/x/tools/cmd/stringer
go get -u -v $(GOTOOLS)
go list ./... \
| xargs go list -f '{{join .Deps "\n"}}' \
| grep -v github.com/hashicorp/consul \
Expand All @@ -43,9 +44,6 @@ test: deps
@./scripts/test.sh
@$(MAKE) vet

integ:
go list ./... | INTEG_TESTS=yes xargs -n1 go test

cover: deps
./scripts/verify_no_uuid.sh
go list ./... | xargs -n1 go test --cover
Expand Down Expand Up @@ -76,4 +74,4 @@ web:
web-push:
./scripts/website_push.sh

.PHONY: all bin dev dist cov deps integ test vet web web-push generate test-nodep
.PHONY: all bin dev dist cov deps test vet web web-push generate test-nodep
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ http://www.consul.io/docs
## Developing Consul

If you wish to work on Consul itself, you'll first need [Go](https://golang.org)
installed (version 1.4+ is _required_). Make sure you have Go properly installed,
installed (version 1.5.1+ is _required_). Make sure you have Go properly installed,
including setting up your [GOPATH](https://golang.org/doc/code.html#GOPATH).

Next, clone this repository into `$GOPATH/src/github.com/hashicorp/consul` and
Expand All @@ -66,7 +66,7 @@ format the code according to Go standards.

### Building Consul on Windows

Make sure Go 1.4+ is installed on your system and that the Go command is in your
Make sure Go 1.5.1+ is installed on your system and that the Go command is in your
%PATH%.

For building Consul on Windows, you also need to have MinGW installed.
Expand Down
13 changes: 4 additions & 9 deletions Vagrantfile
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
VAGRANTFILE_API_VERSION = '2'

@script = <<SCRIPT
GOVERSION="1.5.1"
SRCROOT="/opt/go"
SRCPATH="/opt/gopath"

Expand All @@ -17,8 +18,8 @@ sudo apt-get install -y build-essential git-core

# Install Go
cd /tmp
wget --quiet --no-check-certificate https://storage.googleapis.com/golang/go1.4.2.linux-${ARCH}.tar.gz
tar -xvf go1.4.2.linux-${ARCH}.tar.gz
wget --quiet --no-check-certificate https://storage.googleapis.com/golang/go${GOVERSION}.linux-${ARCH}.tar.gz
tar -xvf go${GOVERSION}.linux-${ARCH}.tar.gz
sudo mv go $SRCROOT
sudo chmod 775 $SRCROOT
sudo chown vagrant:vagrant $SRCROOT
Expand Down Expand Up @@ -56,14 +57,8 @@ Vagrant.configure(VAGRANTFILE_API_VERSION) do |config|
end
end

# Note we use older boxes here to avoid glibc version check problems with
# the built C dependencies.
config.vm.define '64bit' do |n1|
n1.vm.box = 'chef/ubuntu-10.04'
end

config.vm.define '32bit' do |n2|
n2.vm.box = 'chef/ubuntu-10.04-i386'
n1.vm.box = 'hashicorp/precise64'
end

config.push.define "www", strategy: "local-exec" do |push|
Expand Down
8 changes: 2 additions & 6 deletions make.bat
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ if x%1==xdeps goto end
goto args

:args
for %%a in (all,cover,integ,test,vet,updatedeps) do (if x%1==x%%a goto %%a)
for %%a in (all,cover,test,vet,updatedeps) do (if x%1==x%%a goto %%a)
echo.
echo Unknown make target: %1
echo Expected one of "all", "cover", "deps", "integ", "test", "vet", or "updatedeps".
echo Expected one of "all", "cover", "deps", "test", "vet", or "updatedeps".
set _EXITCODE=1
goto end

Expand All @@ -45,10 +45,6 @@ go tool cover 2>NUL
if %ERRORLEVEL% EQU 3 go get golang.org/x/tools/cmd/cover
goto test

:integ
set INTEG_TESTS=yes
goto test

:test
call .\scripts\windows\verify_no_uuid.bat %CD%
if %ERRORLEVEL% EQU 0 goto _test
Expand Down
4 changes: 2 additions & 2 deletions version.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ var (
)

// The main version number that is being run at the moment.
const Version = "0.5.2"
const Version = "0.6.0"

// A pre-release marker for the version. If this is "" (empty string)
// then it means that it is a final release. Otherwise, this is a pre-release
// such as "dev" (in development), "beta", "rc1", etc.
const VersionPrerelease = ""
const VersionPrerelease = "rc1"