-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport of Docs/reformat service splitters conf entry into release/1.15.x #16283
Merged
trujillo-adam
merged 11 commits into
release/1.15.x
from
backport/docs/reformat-service-splitters-conf-entry/painfully-credible-mako
Feb 21, 2023
Merged
Backport of Docs/reformat service splitters conf entry into release/1.15.x #16283
trujillo-adam
merged 11 commits into
release/1.15.x
from
backport/docs/reformat-service-splitters-conf-entry/painfully-credible-mako
Feb 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-consul-core
force-pushed
the
backport/docs/reformat-service-splitters-conf-entry/painfully-credible-mako
branch
from
February 15, 2023 22:38
ce305b1
to
5af004a
Compare
* for tab testing * updates * Update * adding sandbox to test conf ref types * testing tweaks to the conf ref template * reintroduce tabbed specification * applied feedback from MKO session * applied feedback on format from luke and jared * Apply suggestions from code review Co-authored-by: Dan Upton <daniel@floppy.co> * fixed some minor HCL formatting in complete conf * Apply suggestions from code review Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> * fixed bad link * resolving conflicts --------- Co-authored-by: boruszak <jeffrey.boruszak@hashicorp.com> Co-authored-by: Dan Upton <daniel@floppy.co> Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com> resolved cherry-pick conflicts
…itters-conf-entry/painfully-credible-mako
trujillo-adam
approved these changes
Feb 21, 2023
trujillo-adam
deleted the
backport/docs/reformat-service-splitters-conf-entry/painfully-credible-mako
branch
February 21, 2023 20:24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #16264 to be assessed for backporting due to the inclusion of the label type/docs-cherrypick.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Description
This PR reformats the service splitter configuration entries reference documentation to the standard defined in our content types guidelines. The changes are mostly about formatting how the information is presented, so the text is the same or similar for most fields. We edited some of the content for clarity, though, which should be verified before merging.
PR Checklist
Overview of commits