Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of fixes for unsupported partitions field in CRD metadata block into release/1.15.x #16606

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #16604 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

We incorrectly documented that the metadata.partitions field is supported for some K8s CRDs. This PR removes the field and, in the appropriate context, explains that the pod inherits the partition configuration.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/remove-partition-from-crds-docs/poorly-choice-stork branch from d8b91a5 to 46cd37c Compare March 10, 2023 19:34
@hc-github-team-consul-core hc-github-team-consul-core requested a review from a team as a code owner March 10, 2023 19:34
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/remove-partition-from-crds-docs/poorly-choice-stork branch from 46cd37c to 76cdb92 Compare March 10, 2023 19:34
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) March 10, 2023 19:34
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/docs/remove-partition-from-crds-docs/poorly-choice-stork branch from 64fc0a0 to d5a0b2e Compare March 10, 2023 19:34
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 71a3e9f into release/1.15.x Mar 10, 2023
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Mar 10, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/docs/remove-partition-from-crds-docs/poorly-choice-stork branch March 10, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants