Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of APIGW: Update how status conditions for certificates are handled into release/1.15.x #17170

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17115 to be assessed for backporting due to the inclusion of the label backport/1.15.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

merge conflict error: POST https://api.github.com/repos/hashicorp/consul/merges: 409 Merge conflict []

The below text is copied from the body of the original PR.


Description

This changes how status conditions for invalid certifcates on listeners are reported so that the status condition is on the listener and mentions which certificate is invalid in the message.

Testing & Reproduction steps

Run unit tests

Links

N/A

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit branch from f048d35 to ad98357 Compare April 27, 2023 15:55
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit branch from ad98357 to f048d35 Compare April 27, 2023 15:55
@hashicorp-cla
Copy link

hashicorp-cla commented Apr 27, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@sarahalsmiller sarahalsmiller force-pushed the backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit branch from 8d81538 to ab4890c Compare June 22, 2023 21:07
)

* Move status condition for invalid certifcate to reference the listener
that is using the certificate

* Fix where we set the condition status for listeners and certificate
refs, added tests

* Add changelog
@nathancoleman nathancoleman force-pushed the backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit branch from ab4890c to efee5ee Compare June 22, 2023 21:25
@sarahalsmiller sarahalsmiller marked this pull request as ready for review June 22, 2023 21:48
@sarahalsmiller sarahalsmiller merged commit 1291786 into release/1.15.x Jun 22, 2023
@sarahalsmiller sarahalsmiller deleted the backport/NET-2029/update-status-condition-for-listeners/horribly-promoted-hermit branch June 22, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants