Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backport PR 15979 to 1.15.x #17208

Merged
merged 6 commits into from
May 10, 2023
Merged

backport PR 15979 to 1.15.x #17208

merged 6 commits into from
May 10, 2023

Conversation

malizz
Copy link
Contributor

@malizz malizz commented May 1, 2023

Description

This PR is a manual backport of PR: #15979

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@malizz malizz requested review from analogue and thisisnotashwin May 1, 2023 22:19
@github-actions github-actions bot added theme/api Relating to the HTTP API interface theme/envoy/xds Related to Envoy support labels May 1, 2023
@malizz malizz requested a review from DanStough May 4, 2023 16:58
@malizz malizz force-pushed the malizz/NET-1646/backport-pr-15979 branch from 65d827d to 75b70aa Compare May 9, 2023 21:15
github-team-consul-core-pr-approver
github-team-consul-core-pr-approver approved these changes May 9, 2023
View reviewed changes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@malizz malizz merged commit 734d7a2 into release/1.15.x May 10, 2023
@malizz malizz deleted the malizz/NET-1646/backport-pr-15979 branch May 10, 2023 00:25
@jjti jjti mentioned this pull request Aug 28, 2023
Closed
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-team-consul-core-pr-approver github-team-consul-core-pr-approver github-team-consul-core-pr-approver approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

@analogue analogue Awaiting requested review from analogue

@DanStough DanStough Awaiting requested review from DanStough

Assignees
No one assigned
Labels
pr/no-backport theme/api Relating to the HTTP API interface theme/envoy/xds Related to Envoy support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@malizz @thisisnotashwin @github-team-consul-core-pr-approver