Add new fields to HCP bootstrap config request and push state request #17296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pr/dependencies
hanshasselberg
added
pr/no-changelog
hanshasselberg
force-pushed
the
hans/add_new_field_to_bootstrap_config_and_push_state
branch
from
ed54e24 to
9144ed8
Compare
hanshasselberg
changed the title
hanshasselberg
force-pushed
the
hans/add_new_field_to_bootstrap_config_and_push_state
branch
from
cfb9275 to
85f27f5
Compare
loshz
reviewed
May 11, 2023
agent/hcp/client.go
Outdated
| @@ -18,6 +18,7 @@ import ( | |||
|
|
|||
| "github.com/hashicorp/consul/agent/hcp/config" | |||
| "github.com/hashicorp/consul/version" | |||
| consulversion "github.com/hashicorp/consul/version" | |||
There was a problem hiding this comment.
This is the same dep imported on the line above.
There was a problem hiding this comment.
good find, fixed.
|
Just need to gofmt |
loshz
approved these changes
May 12, 2023
freddygv
deleted the
hans/add_new_field_to_bootstrap_config_and_push_state
branch
This was referenced May 13, 2023
hanshasselberg
added a commit
that referenced
this pull request
May 13, 2023
* update hcp-sdk-go * add version, datacenter and acl info * fewer changes * go mod tidy and lint * less code * remove duplicated dep * fmt * go mod tidy
hanshasselberg
added a commit
that referenced
this pull request
May 13, 2023
* update hcp-sdk-go * add version, datacenter and acl info * fewer changes * go mod tidy and lint * less code * remove duplicated dep * fmt * trigger ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
To support linking cluster, HCP needs to know the datacenter and if ACLs are enabled. Otherwise hosted Consul Core UI won't work properly.
Testing & Reproduction steps
Links
PR Checklist