-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prototest: fix early return condition in AssertElementsMatch #17416
Conversation
@@ -63,8 +70,8 @@ func AssertElementsMatch[V any]( | |||
} | |||
} | |||
|
|||
if len(outX) == len(outY) && len(listX) == len(listY) { | |||
return // matches | |||
if len(outX) == len(listX) && len(outY) == len(listY) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the bug.
Prefer the improved test in this commit 9fbced6 where |
…he backend so Version stays in sync
manual backport of #17416 to 1.15.x
manual backport of #17416 to 1.15.x
manual backport of #17416 to 1.13.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
manual backport of #17416 to 1.14.x
Since the failed tests were all in features recently changed, the backports were all done manually to elide the irrelevant changes. |
Description
prototest.AssertElementsMatch
has an early return condition that returned early incorrectly when two slices were actually different.