Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENT->OSS merge for Consolidate ListEnvoyExtender into `BasicEnvoyEx… #17491

Merged
merged 1 commit into from
May 26, 2023
Merged

ENT->OSS merge for Consolidate ListEnvoyExtender into `BasicEnvoyEx… #17491

merged 1 commit into from
May 26, 2023

Conversation

cthain
Copy link
Contributor

@cthain cthain commented May 26, 2023

Description

This PR introduces the following changes to simplify the maintenance and use of the envoyextensions/extensioncommon package:

  • Augment the interface for BasicEnvoyExtender to support patching lists of resources.
  • Merge the functionality provided by ListEnvoyExtender into BasicEnvoyExtender
  • Create a new BasicExtensionAdapter struct that provides no-op implementations of all the extender interfaces so extensions need only implement the interfaces they care about.
  • Move some common functions into the resources.go file.
  • Add some new common functions for modifying lists of Envoy filters.

Testing & Reproduction steps

  • Existing Envoy golden tests for the builtin extensions all pass without modification.
  • Unit tests have been added for net-new functionality.

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

@cthain cthain added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-backport labels May 26, 2023
@cthain cthain requested review from erichaberkorn and zalimeni May 26, 2023 16:54
@cthain cthain self-assigned this May 26, 2023
@cthain cthain merged commit 2740d12 into main May 26, 2023
@cthain cthain deleted the cthain/envoy-extension-updates branch May 26, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zalimeni zalimeni zalimeni approved these changes

@erichaberkorn erichaberkorn Awaiting requested review from erichaberkorn

Assignees

@cthain cthain

Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry pr/no-docs PR does not include docs and should not trigger reminder for cherrypicking them. pr/no-metrics-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cthain @zalimeni