Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Test permissive mTLS filter chain is not configured with tproxy disabled into release/1.16.x #17812

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #17747 to be assessed for backporting due to the inclusion of the label backport/1.16.

The below text is copied from the body of the original PR.


Description

This adds a golden data test to validate the permissive mTLS listener modifications are not applied when transparent proxy is disabled and permissive mTLS is enabled.

Testing & Reproduction steps

go test -v -run TestListenersFromSnapshot/envoy-1.23.10/connect-proxy-without-tproxy-and-permissive-mtls/current 

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/pglass/NET-4488/pmtls-test-follow-up/nicely-real-mastiff branch from 859baad to 79b1509 Compare June 20, 2023 14:50
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/pglass/NET-4488/pmtls-test-follow-up/nicely-real-mastiff branch from a4fb86a to 0f71f30 Compare June 20, 2023 14:50
@hc-github-team-consul-core hc-github-team-consul-core enabled auto-merge (squash) June 20, 2023 14:50
@github-actions github-actions bot added the theme/envoy/xds Related to Envoy support label Jun 20, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core hc-github-team-consul-core merged commit 99bef41 into release/1.16.x Jun 20, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/pglass/NET-4488/pmtls-test-follow-up/nicely-real-mastiff branch June 20, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme/envoy/xds Related to Envoy support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants