Backport of ext-authz Envoy extension: support localhost as a valid target URI into release/1.16.0 #17838
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is for backporting #17821 to release/1.16.0
The below text is copied from the body of the original PR.
Description
This PR fixes a bug in the
builtin/ext-authz
extension when usinglocalhost
as the target URI. When using an upstream on the localhost network we configure aSTATIC
cluster type that requires using an IP address. The extension was configuring the cluster with thelocalhost
hostname, which caused Envoy to reject the xDS configuration update with an error similar to:Testing & Reproduction steps
agent/xds
golden tests to ensure that IP addresses result in aSTATIC
cluster type and thatlocalhost
results in aSTRICT_DNS
cluster type, when creating the cluster definition.ext-authz
extension to cover some additional error cases.PR Checklist