Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of Passes configured role name to Vault for AWS auth in Connect CA into release/1.16.x #18099

Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
backport of commit 7282078
  • Loading branch information
t-davies authored and cthain committed Jul 12, 2023
commit 8ed33a39a939fc99d11a75d2d03a8529892a3a30
3 changes: 0 additions & 3 deletions agent/connect/ca/provider_vault_auth_aws.go
Original file line number Diff line number Diff line change
@@ -72,9 +72,6 @@ func (g *AWSLoginDataGenerator) GenerateLoginData(authMethod *structs.VaultAuthM
if err != nil {
return nil, fmt.Errorf("aws auth failed to generate login data: %w", err)
}
if loginData == nil {
return nil, fmt.Errorf("got nil response from GenerateLoginData")
}

// If a Vault role name is specified, we need to manually add this
role, ok := authMethod.Params["role"]