Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of NET-5049: subscribe to bound-api-gateway only after receiving api-gateway into release/1.15.x #18294

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18291 to be assessed for backporting due to the inclusion of the label backport/1.15.

The below text is copied from the body of the original PR.


Description

This fixes a race condition due to our dependency on having the listener(s) from the api-gateway config entry in order to fully and properly process the resources on the bound-api-gateway config entry.

Testing & Reproduction steps

Existing tests should all pass

Links

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@vercel vercel bot temporarily deployed to Preview – consul-ui-staging July 26, 2023 20:05 Inactive
@nathancoleman nathancoleman changed the title Backport of api-gateway: subscribe to bound-api-gateway only after receiving api-gateway into release/1.15.x Backport of NET-5049: subscribe to bound-api-gateway only after receiving api-gateway into release/1.15.x Jul 26, 2023
@vercel vercel bot temporarily deployed to Preview – consul July 26, 2023 20:08 Inactive
@hc-github-team-consul-core hc-github-team-consul-core merged commit 3980a28 into release/1.15.x Jul 26, 2023
@hc-github-team-consul-core hc-github-team-consul-core deleted the backport/bound-api-gtw-sub/mostly-huge-alien branch July 26, 2023 22:26
@jira jira bot mentioned this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants