Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NET-6295] Backport of Add grpc keepalive configuration into release/1.15.x (#19… #19347

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[NET-6295] Backport of Add grpc keepalive configuration into release/1.15.x (#19… #19347

merged 1 commit into from
Oct 24, 2023

Conversation

hashi-derek
Copy link
Member

Manual backport of #19339

@hashi-derek
Backport of Add grpc keepalive configuration into release/1.15.x (#19339
808c7ea 
)

Add grpc keepalive configuration. (#19339)

Prior to the introduction of this configuration, grpc keepalive messages were
sent after 2 hours of inactivity on the stream. This posed issues in various
scenarios where the server-side xds connection balancing was unaware that envoy
instances were uncleanly killed / force-closed, since the connections would
only be cleaned up after ~5 minutes of TCP timeouts occurred. Setting this
config to a 30 second interval with a 20 second timeout ensures that at most,
it should take up to 50 seconds for a dead xds connection to be closed.
@hashi-derek hashi-derek added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport labels Oct 24, 2023
@github-actions github-actions bot added type/docs Documentation needs to be created/updated/clarified theme/config Relating to Consul Agent configuration, including reloading labels Oct 24, 2023
@hc-github-team-consul-core
Copy link
Collaborator

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@hashi-derek hashi-derek marked this pull request as ready for review October 24, 2023 13:41
@hashi-derek hashi-derek requested review from a team as code owners October 24, 2023 13:41
@hashi-derek hashi-derek merged commit d0fea44 into release/1.15.x Oct 24, 2023
94 checks passed
@hashi-derek hashi-derek deleted the derekm/grpc-server-keepalive-1.15.x branch October 24, 2023 13:52
@hashi-derek hashi-derek changed the title Backport of Add grpc keepalive configuration into release/1.15.x (#19… [NET-6295] Backport of Add grpc keepalive configuration into release/1.15.x (#19… Oct 24, 2023
@dlaguerta dlaguerta mentioned this pull request Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@curtbushko curtbushko curtbushko approved these changes

Assignees
No one assigned
Labels
pr/no-backport pr/no-changelog PR does not need a corresponding .changelog entry theme/config Relating to Consul Agent configuration, including reloading type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hashi-derek @hc-github-team-consul-core @curtbushko