Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of [Docs] Update admin-partitions.mdx into release/1.15.x #19630

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

hc-github-team-consul-core
Copy link
Collaborator

Backport

This PR is auto-generated from #18430 to be assessed for backporting due to the inclusion of the label backport/1.15.

🚨

Warning automatic cherry-pick of commits failed. If the first commit failed,
you will see a blank no-op commit below. If at least one commit succeeded, you
will see the cherry-picked commits up to, not including, the commit where
the merge conflict occurred.

The person who merged in the original PR is:
@im2nguyen
This person should manually cherry-pick the original PR into a new backport PR,
and close this one when the manual backport PR is merged in.

merge conflict error: unable to process merge commit: "88434d96f7bf7ba3349f70fe71141f9c41ed7464", automatic backport requires rebase workflow

The below text is copied from the body of the original PR.


Description

Adding a note on DNS queries requiring the presence of a Consul Client in the Admin partition

Testing & Reproduction steps

The consul-dns endpoints are the consul clients and servers as seen In the Helm chart consul/templates/dns-service.yaml
selector:
app: {{ template "consul.name" . }}
release: "{{ .Release.Name }}"
hasDNS: "true"

All components have the first two labels for app and release but only consul clients and servers have the last one hasDNS so it will only match clients AND servers

grep hasDNS ./* 2> /dev/null
./client-daemonset.yaml: hasDNS: "true"
./dns-service.yaml: hasDNS: "true"
./server-statefulset.yaml: hasDNS: "true"

PR Checklist

  • updated test coverage
  • external facing docs updated
  • appropriate backport labels added
  • not a security concern

Overview of commits

@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/am-ak-patch-1/partly-good-dinosaur branch from cbfdf86 to ee9dd5e Compare November 14, 2023 17:11
@hc-github-team-consul-core hc-github-team-consul-core force-pushed the backport/am-ak-patch-1/partly-good-dinosaur branch from a38894c to 3ce5fca Compare November 14, 2023 17:11
@github-actions github-actions bot added the type/docs Documentation needs to be created/updated/clarified label Nov 14, 2023
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto approved Consul Bot automated PR

@hc-github-team-consul-core
Copy link
Collaborator Author

🤔 This PR has changes in the website/ directory but does not have a type/docs-cherrypick label. If the changes are for the next version, this can be ignored. If they are updates to current docs, attach the label to auto cherrypick to the stable-website branch after merging.

@vercel vercel bot temporarily deployed to Preview – consul November 14, 2023 17:22 Inactive
@im2nguyen im2nguyen marked this pull request as ready for review November 14, 2023 17:27
@im2nguyen im2nguyen requested a review from a team as a code owner November 14, 2023 17:27
@im2nguyen im2nguyen merged commit 789affd into release/1.15.x Nov 14, 2023
47 of 48 checks passed
@im2nguyen im2nguyen deleted the backport/am-ak-patch-1/partly-good-dinosaur branch November 14, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants