Backport of [NET-10737] Add CI Checks for Generated Testdata into release/1.19.x #21615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-team-consul-core-pr-approver
approved these changes
Aug 19, 2024
github-actions
bot
added
type/ci
jm96441n
approved these changes
Aug 19, 2024
jm96441n
deleted the
backport/NET-10737-check-for-xds-diffs-in-ci/virtually-informed-aphid
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #21613 to be assessed for backporting due to the inclusion of the label backport/1.19.
The below text is copied from the body of the original PR.
Description
Adds tests to CI to ensure that xds golden files that are generated for tests are up to date
Testing & Reproduction steps
The core of the script is the following line:
changed_xds_files=$(git --no-pager diff --name-only HEAD "$(git merge-base HEAD "$GITHUB_BASE_REF")" | egrep "agent/xds/testdata/.*")you can replace
$GITHUB_BASE_REFwith an earlier release branch (I useorigin/release/1.17.x) to see it find diffs for golden filesLinks
PR Checklist
Overview of commits