Give a valid service address in SRV lookup when it differs from the node's #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slackpad
reviewed
Oct 28, 2016
| @@ -357,6 +358,46 @@ PARSE: | |||
| query := strings.Join(labels[:n-1], ".") | |||
| d.preparedQueryLookup(network, datacenter, query, req, resp) | |||
|
|
|||
| case "addr": | |||
| if n < 2 { | |||
There was a problem hiding this comment.
This should probably be != 2 so we don't accept any periods, since we know it's just hex stuff.
|
LGTM - one tiny thing and then the IPv6 test and this should be gtg! |
slackpad
reviewed
Oct 28, 2016
| if !ok { | ||
| t.Fatalf("Bad: %#v", in.Extra[0]) | ||
| } | ||
| if aRec.Hdr.Name != "2607002040050808000000000000200e.addr.dc1.consul." { |
There was a problem hiding this comment.
lol these hex names are 1337
|
Addressed the comment and added a couple tests for lookups on 'addr.consul' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #832
Still need to add a 'TestDNS_ServiceLookup_ServiceAddressIPv6' test, I think that's the only thing missing here.