Adding support for 'watches' #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| Watches are a way of specifying a view of data (list of nodes, KV pairs, | ||
| health checks, etc) which is monitored for any updates. When an update | ||
| is detected, an external handler handler is invoked. A handler can be any |
There was a problem hiding this comment.
Typo s/handler handler/handler/
|
|
|
yay! |
|
👍 |
|
Great work @armon! |
|
👍 awesome! |
| flag = "-c" | ||
| } | ||
| cmd := exec.Command(shell, flag, script) | ||
| return cmd, nil |
There was a problem hiding this comment.
never returns error?
There was a problem hiding this comment.
Not currently, but it forces code upstream to check for a possible error
duckhan
pushed a commit
to duckhan/consul
that referenced
this pull request
Oct 24, 2021
Allow setting hostPath for client data directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for "watches". Watches are similar to Serf events: they allow an external handler to be invoked when data changes in Consul. They are implemented by wrapping blocking queries, with automatic management of the lifecycle.