Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vendor: update github.com/fsouza/go-dockerclient #3257

Closed
wants to merge 2 commits into from
Closed

vendor: update github.com/fsouza/go-dockerclient #3257

wants to merge 2 commits into from

Conversation

magiconair
Copy link
Contributor

Update go-dockerclient to version 5ea18ed which contains
the fix for go-dockerclient#622.

Fixes #3254

@magiconair
Copy link
Contributor Author

I've created the minimal lib upgrade since upgrading it to the latest version requires to upgrade and extend the docker import which wants three other libs....

@magiconair magiconair mentioned this pull request Jul 11, 2017
Closed
@magiconair
vendor: update github.com/fsouza/go-dockerclient
7b7898e 
Update go-dockerclient and dependant dependencies
to add fix for go-dockerclient#622.

Fixes #3254
@magiconair
vendor: github.com/Sirupsen -> github.com/sirupsen
3904a12
@magiconair magiconair force-pushed the issue-3254-upgrade-dockerclient branch from 83b7e4a to 3904a12 Compare July 11, 2017 23:19
@magiconair
Copy link
Contributor Author

Fixing this required a somewhat insane amount of dependency update including with a naming clash for the github.com/sirupsen/logrus lib. I will have a look to implement this feature in a different way so that we can drop these dependencies altogether.

Could you have another look, please?

@magiconair
Copy link
Contributor Author

Merged

@magiconair magiconair closed this Jul 14, 2017
@magiconair magiconair mentioned this pull request Jul 14, 2017
Closed
@magiconair magiconair deleted the issue-3254-upgrade-dockerclient branch July 14, 2017 21:53
magiconair added a commit that referenced this pull request Jul 14, 2017
@magiconair
agent: replace docker check
fa84b3e 
This patch replaces the Docker client which is used
for health checks with a simplified version tailored
for that purpose.

See #3254
See #3257
Fixes #3270
magiconair added a commit that referenced this pull request Jul 16, 2017
@magiconair
agent: replace docker check
e31d405 
This patch replaces the Docker client which is used
for health checks with a simplified version tailored
for that purpose.

See #3254
See #3257
Fixes #3270
magiconair added a commit that referenced this pull request Jul 18, 2017
@magiconair
agent: replace docker check
b514187 
This patch replaces the Docker client which is used
for health checks with a simplified version tailored
for that purpose.

See #3254
See #3257
Fixes #3270
magiconair added a commit that referenced this pull request Jul 18, 2017
@magiconair
agent: replace docker check
2123700 
This patch replaces the Docker client which is used
for health checks with a simplified version tailored
for that purpose.

See #3254
See #3257
Fixes #3270
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Old vendored fsouza/go-dockerclient doesn't have fix for failing docker check connection
1 participant
@magiconair