Commits on Jul 14, 2017

1. accept recv-only channels for cancellations …

   Cancellation channels are often derived from a Context, which
   returns a directional `<-chan struct{}` from Done(). In order to use
   this with parts of of the consul API, one is required to create a new
   channel and dispatch a separate goroutine to watch for context
   cancellation and close the new channel.
   
   Changing the signature for the methods that take cancellation channels
   will allow easier integration with existing uses of Context. Since the
   cancellation pattern only reads from these channels, there should be no
   backwards incompatibility with existing codebases, and most of the
   methods already accept only the correct type.

   

   jbardin committed Jul 14, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for 6b0683c
   • Browse repository at this point

   Copy the full SHA

   6b0683c View commit details

   Browse the repository at this point in the history