Replace Statsite prefix with Service prefix #3293
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VoyTechnology
changed the title
slackpad
added
type/enhancement
|
This needs to come after #3480 is merged. |
|
@VoyTechnology if you feel comfortable then I'd ask you to rewrite that change on top of the refactor-config branch since we're going to merge that soon. This will change the entire handling of configuration for the agent. Otherwise, I'll pick this up. |
|
Thanks for response :) I forgot about this change. Will look at it soon |
Merged
magiconair
added a commit
that referenced
this pull request
Sep 26, 2017
The metrics prefix isn't statsite specific and is in fact used for all metrics providers. Since we are deprecating fields anyway we should fix this one as well. Fixes #3293
|
Since we're breaking things for 1.0 anyway we might just do this one properly. We will pull all the doc fixes into a separate commit. I'll close this one in favor of #3498 . Thanks for your submission! |
slackpad
pushed a commit
that referenced
this pull request
Sep 27, 2017
* metrics: replace statsite_prefix with service_prefix The metrics prefix isn't statsite specific and is in fact used for all metrics providers. Since we are deprecating fields anyway we should fix this one as well. Fixes #3293 * Updates docs and sorts telemetry section. * Renames to "metrics_prefix" to disambiguate with Consul services. * Updates the change log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
sitestat_prefixis used for all metrics. This is very counterintuitive. This change adds aservice_prefixconfiguration option instead and deprecatessitestat_prefix.Also included: