watch: Disable monotonicity check for lastIndex when type is "event" #3625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since lastIndex is not monotonic when type of a watch is "event", we have to disable the monotonicity check for the "event."
|
Hi @slackpad, sorry to bother you. Do you have any news on this PR? |
|
I found that the same issue is also reported in #3443. |
|
Linking to #3742. |
|
This should have been fixed by #3742. |
|
Hey there, This issue has been automatically locked because it is closed and there hasn't been any activity for at least 30 days. If you are still experiencing problems, or still have questions, feel free to open a new one 👍. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Consul v0.8.4 or later,
consul watch -type event childinvokes a child process several time with the same events, which is unexpected.Description: https://gist.github.com/yunazuno/798372ec53b01cf36e7ef00b691ba3ae
This problem is possibly caused by a monotonicity check for
p.lastIndexinwatch/plan.go.Unlike the other watch types, "event" doesn't have monotonic index. Therefore, the monotonicity check sometime unexpectedly resets
p.lastIndex.This PR disables the monotonicity check when type of a watch is "event" in order to prevent the issue.