Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch dns vendor code for picking up a TCP DOS attack bugfix #3861

Merged
merged 1 commit into from
Feb 5, 2018

Conversation

preetapan
Copy link
Contributor

@preetapan preetapan commented Feb 5, 2018

Fixes #3859

@preetapan preetapan requested a review from slackpad February 5, 2018 23:07
Copy link
Contributor

@slackpad slackpad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@preetapan preetapan merged commit b1c487f into master Feb 5, 2018
@slackpad slackpad deleted the dns_tcp_dos_monkeypatch branch February 8, 2018 01:31
}
srv.inFlight.Add(1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This WaitGroup change looks like part of some other refactor we didn't take because we were just trying to take the CVE patch. It looks like there's a behavior here we broke leading to #3877.

slackpad added a commit that referenced this pull request Feb 9, 2018
This came in via the monkey patch in #3861.

Fixes #3877
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants