Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow ignoring checks by ID when defining a PreparedQuery. Fixes #3727. #4022

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

banks
Copy link
Member

@banks banks commented Apr 10, 2018

As documented, this new field for prepared queries allows filtering out specific checks by ID that are known to be inaccurate.

It's intended as an emergency or temporary measure where a simple update to a centrally defined query (template) can bypass a faulty check without deregistering it everywhere.

PR includes:

  • Struct filtering changes and test
  • RPC execute changes and test
  • Agent HTTP endpoint changes and test
  • api client struct changes and test
  • Documentation update
  • Added test for PreparedQuery template rendering that interpolation works inside the IgnoreCheckIDs (despite the type difference)

@banks banks force-pushed the pq-filter-checks branch 2 times, most recently from 343482f to e798a3b Compare April 10, 2018 13:01
@banks banks force-pushed the pq-filter-checks branch from e798a3b to 0d8993e Compare April 10, 2018 13:04
@pearkes pearkes added this to the 1.0.7 milestone Apr 10, 2018
Copy link
Contributor

@kyhavlov kyhavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@banks banks merged commit 6abc465 into master Apr 11, 2018
@banks banks deleted the pq-filter-checks branch April 11, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants