Only call signal.Notify once during agent startup #4024
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling twice appears to have no adverse effects, however serves to confuse as to what the semantics of such code may be! After some experimentation it seems that the second
signal.Notify
takes precedence over the first, rather than resulting in two messages being delivered to the signal channel, so there is no change in behaviour resulting from this change.This seems like it was probably introduced while resolving conflicts during the merge of the fix for #2404.