Catalog Register: Generate UUID for services registered without one #4294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the behavior line up with the docs and expected behavior
mitchellh
approved these changes
Jun 27, 2018
agent/catalog_endpoint_test.go
Outdated
| "github.com/hashicorp/consul/testutil/retry" | ||
| "github.com/hashicorp/serf/coordinate" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
Nit: Is this an artifact of the GitHub diff viewer or are these not tabbed/formatted properly?
There was a problem hiding this comment.
Right you are, looks like something happened to my editor plugin to run go fmt on save.
agent/consul/catalog_endpoint.go
Outdated
| return fmt.Errorf("Failed to generate ID: %v", err) | ||
| } | ||
|
|
||
| args.ID = types.NodeID(id) |
There was a problem hiding this comment.
Same question here, is this formatted properly (go fmt)?
|
Oh follow up question: should the default UUID test actually go in |
|
@mitchellh There are actually two catalog_endpoint_test.go files. Looks like I dropped it in the wrong one. |
mkeeler
force-pushed
the
bugfix/4249-gen-ext-node-id
branch
from
08e3bbd
to
0f70034
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4249
This makes the behavior line up with the docs and expected behavior