Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old fork of text package #4501

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Replace old fork of text package #4501

merged 1 commit into from
Aug 14, 2018

Conversation

shubheksha
Copy link
Contributor

Fixes #4269
/cc @pearkes

@pearkes
Copy link
Contributor

pearkes commented Aug 10, 2018

Thanks for the PR @shubheksha. Looks like you may need to re-run the vendoring to resolve conflicts, and then run make vendorfmt which formats the vendor.json file to make diffs cleaner.

@shubheksha
Copy link
Contributor Author

@pearkes Done!

@@ -99,12 +99,12 @@
{"path":"github.com/hashicorp/hil","checksumSHA1":"kqCMCHy2b+RBMKC+ER+OPqp8C3E=","revision":"1e86c6b523c55d1fa6c6e930ce80b548664c95c2","revisionTime":"2016-07-11T23:18:37Z"},
{"path":"github.com/hashicorp/hil/ast","checksumSHA1":"UICubs001+Q4MsUf9zl2vcMzWQQ=","revision":"1e86c6b523c55d1fa6c6e930ce80b548664c95c2","revisionTime":"2016-07-11T23:18:37Z"},
{"path":"github.com/hashicorp/logutils","checksumSHA1":"vt+P9D2yWDO3gdvdgCzwqunlhxU=","revision":"0dc08b1671f34c4250ce212759ebd880f743d883","revisionTime":"2015-06-09T07:04:31Z"},
{"path":"github.com/hashicorp/memberlist","checksumSHA1":"q6yTL5vSGnWxUtcocVU3YIG/HNc=","revision":"b195c8e4fcc6284fff1583fd6ab09e68ca207551","revisionTime":"2018-08-09T14:04:54Z"},
{"path":"github.com/hashicorp/memberlist","checksumSHA1":"88DoUaWD6hS1KTt57RMQ7wxHu/k=","revision":"9bdd37bfb26bd039c08b0f36be6f80ceede4aaf3","revisionTime":"2017-11-17T04:34:18Z"},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you may need to rebase to get these changes removed. They were added in #4511. I believe you can also use govendor to target a specific package, too, to avoid this diff.

@shubheksha
Copy link
Contributor Author

@pearkes, should be fixed now 😄

@pearkes
Copy link
Contributor

pearkes commented Aug 14, 2018

Thanks!

@pearkes pearkes merged commit fc3997f into hashicorp:master Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants