Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename agent/proxy package to reflect that it is limited to managed proxy processes. #4550

Merged
merged 2 commits into from
Aug 23, 2018

Commits on Aug 21, 2018

  1. Rename agent/proxy package to reflect that it is limited to managed p…

    …roxy processes
    
    Rationale: we have several other components of the agent that relate to Connect proxies for example the ProxyConfigManager component needed for Envoy work. Those things are pretty separate from the focus of this package so far which is only concerned with managing external proxy processes so it's nota good fit to put code for that in here, yet there is a naming clash if we have other packages related to proxy functionality that are not in the `agent/proxy` package.
    
    Happy to bikeshed the name. I started by calling it `managedproxy` but `managedproxy.Manager` is especially unpleasant. `proxyprocess` seems good in that it's more specific about purpose but less clearly connected with the concept of "managed proxies". The names in use are cleaner though e.g. `proxyprocess.Manager`.
    
    This rename was completed automatically using golang.org/x/tools/cmd/gomvpkg.
    
    Depends on #4541
    banks committed Aug 21, 2018
    Configuration menu
    Copy the full SHA
    f45eab6 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2018

  1. Fix missed windows tagged files

    banks committed Aug 22, 2018
    Configuration menu
    Copy the full SHA
    1b34013 View commit details
    Browse the repository at this point in the history