Implement WarningThreshold for TCP/HTTP HealthChecks #4576
Conversation
pierresouchay
force-pushed
the
WarningThreshold
branch
15 times, most recently
from
9359dc8 to
e7383fe
Compare
|
\o/ All tests are passing ! |
There was a problem hiding this comment.
Great work again Pierre.
I've not looked at the changes in too much detail yet as I'm not yet convinced this is the right direction to go for providing load feedback for loadbalancing. See my comment #4522 (comment) for discussion.
|
@banks Ok, let's see this as another way to have a Warning State then.
On our side, we will probably not use this anyway to achieve such goal, but I had this exact issue for a not maintained anymore PHP script responding after 20 secs on one machine among 3 (because targeted statically by another host while the other 2 were happily answering far less), and I would have loved to be able to fix this that easily. |
It implements setting Warning state for HTTP 200 or when TCP connection succeeds but is too slow as described in hashicorp#4522 Combined with hashicorp#4468 it will allow very easily to reduce calls/secs on slow nodes in a completely automatic way.
pierresouchay
force-pushed
the
WarningThreshold
branch
from
f17e865 to
84b2ce4
Compare
|
Small detail : we should probably also warn when WarningThreshold > 10s as this the hardcoded HTTP timeout. |
|
Closing this PR, discussion here: #4522 (comment). |
It implements setting Warning state for HTTP 200 or when TCP
connection succeeds but is too slow as described
in #4522
Combined with #4468 it will
allow very easily to reduce calls/secs on slow nodes in a
completely automatic way.