Use target service name instead of ID as connect proxy's base service name #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@banks This is a major bug has it breaks Consul Connect for people using ACLs (and service.Name != service.ID) |
banks
approved these changes
Sep 4, 2018
There was a problem hiding this comment.
Thanks @uepoch and @pierresouchay.
Yeah this make sense for now. This was a somewhat known issue and this fix will soon be partly broken by new ACLs that exact match by default (since an ACL for web will no longer allow web-proxy anyway.).
I think the real solution to that is more involved and means changing the ACL rules for registrations where Kind = "connect-proxy".
But this is a great fix for interim and has no real downsides - it makes more sense to operators so see the name rather than ID mirrored too.
uepoch
force-pushed
the
connect-service
branch
3 times, most recently
from
593e631
to
8df6714
Compare
pierresouchay
approved these changes
Sep 4, 2018
uepoch
force-pushed
the
connect-service
branch
from
8df6714
to
1c2b062
Compare
uepoch
force-pushed
the
connect-service
branch
from
1c2b062
to
c5a20ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address #4619
This fix issues appearing when you define a service Name which is not a prefix of the Service ID and have ACL configured for that name
Like
"""
ID: service_id
Name: name_of_service
"""
with an ACL permitting to write only on 'name_of_service*'