Support multiple tags for health and catalog http api endpoints #4717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkeeler
previously requested changes
Oct 3, 2018
agent/consul/health_endpoint_test.go
Outdated
|
|
||
| nodes := out2.Nodes | ||
| if len(nodes) != 1 { | ||
| t.Fatalf("Bad: %v", nodes) |
There was a problem hiding this comment.
For new tests I would recommend importing github.com/stretchr/testify/require and using the functions in there.
This particular block:
if len(nodes) != 1 {
t.Fatalf("Bad: %v", nodes)
}
Can be replaced with:
require.Len(t, nodes, 1)
We already use this in many other places and its more ergonomic than tons of the if / Fatalf blocks
adilyse
force-pushed
the
feature/multiple-tag-filters-1781
branch
2 times, most recently
from
7ae8fd8 to
84012ce
Compare
Fixes #1781. Adds a `ServiceTags` field to the ServiceSpecificRequest to support multiple tags, updates the filter logic in the catalog store, and propagates these change through to the health and catalog endpoints. Note: Leaves `ServiceTag` in the struct, since it is being used as part of the DNS lookup, which in turn uses the health check.
Includes additional tests.
adilyse
force-pushed
the
feature/multiple-tag-filters-1781
branch
from
84012ce to
98cdcaa
Compare
banks
dismissed
mkeeler’s stale review
Was addressed but @mkeeler's not online yet
This was referenced Jan 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1781.
Adds a
ServiceTagsfield to the ServiceSpecificRequest to supportmultiple tags, updates the filter logic in the catalog store, and
propagates these change through to the health and catalog endpoints.
Note: Leaves
ServiceTagin the struct, since it is being used aspart of the DNS lookup, which in turn uses the health check. This
singular field takes precedence over anything in
ServiceTags.