Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Adds multi syntax linting to the code editor #4814

Merged
merged 2 commits into from
Oct 19, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 50 additions & 5 deletions ui-v2/app/components/code-editor.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,57 @@
import Component from '@ember/component';
import qsaFactory from 'consul-ui/utils/dom/qsa-factory';
const $$ = qsaFactory();
import { get, set } from '@ember/object';
import { inject as service } from '@ember/service';
const DEFAULTS = {
tabSize: 2,
lineNumbers: true,
theme: 'hashi',
showCursorWhenSelecting: true,
gutters: ['CodeMirror-lint-markers'],
lint: true,
};
export default Component.extend({
mode: 'application/json',
settings: service('settings'),
helper: service('code-mirror'),
classNames: ['code-editor'],
syntax: '',
onchange: function(value) {
get(this, 'settings').persist({
'code-editor': value,
});
this.setMode(value);
},
onkeyup: function() {},
init: function() {
this._super(...arguments);
set(this, 'modes', get(this, 'helper').modes());
},
setMode: function(mode) {
set(this, 'options', {
...DEFAULTS,
mode: mode.mime,
});
const editor = get(this, 'editor');
editor.setOption('mode', mode.mime);
get(this, 'helper').lint(editor, mode.mode);
set(this, 'mode', mode);
},
didInsertElement: function() {
set(this, 'editor', get(this, 'helper').getEditor(this.element));
get(this, 'settings')
.findBySlug('code-editor')
.then(mode => {
const modes = get(this, 'modes');
const syntax = get(this, 'syntax');
if (syntax) {
mode = modes.find(function(item) {
return item.name.toLowerCase() == syntax.toLowerCase();
});
}
mode = !mode ? modes[0] : mode;
this.setMode(mode);
});
},
didAppear: function() {
const $editor = [...$$('textarea + div', this.element)][0];
$editor.CodeMirror.refresh();
get(this, 'editor').refresh();
},
});
15 changes: 14 additions & 1 deletion ui-v2/app/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,20 @@ <h2>JavaScript Required</h2>
}
</script>
<script src="{{rootURL}}assets/consul-ui.js"></script>

<script>
CodeMirror.modeURL = {
replace: function(n, mode) {
switch(mode) {
case 'javascript':
return '{{rootURL}}assets/codemirror/mode/javascript/javascript.js';
case 'ruby':
return '{{rootURL}}assets/codemirror/mode/ruby/ruby.js';
case 'yaml':
return '{{rootURL}}assets/codemirror/mode/yaml/yaml.js';
}
}
};
</script>
{{content-for "body-footer"}}
</body>
</html>
35 changes: 35 additions & 0 deletions ui-v2/app/initializers/ivy-codemirror.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,44 @@
import { inject as service } from '@ember/service';
import { get } from '@ember/object';
import lint from 'consul-ui/utils/editor/lint';
const MODES = [
{
name: 'JSON',
mime: 'application/json',
mode: 'javascript',
ext: ['json', 'map'],
alias: ['json5'],
},
{
name: 'HCL',
mime: 'text/x-ruby',
mode: 'ruby',
ext: ['rb'],
alias: ['jruby', 'macruby', 'rake', 'rb', 'rbx'],
},
{ name: 'YAML', mime: 'text/x-yaml', mode: 'yaml', ext: ['yaml', 'yml'], alias: ['yml'] },
];
export function initialize(application) {
const IvyCodeMirrorComponent = application.resolveRegistration('component:ivy-codemirror');
const IvyCodeMirrorService = application.resolveRegistration('service:code-mirror');
// Make sure ivy-codemirror respects/maintains a `name=""` attribute
IvyCodeMirrorComponent.reopen({
attributeBindings: ['name'],
});
// Add some method to the code-mirror service so I don't have to have 2 services
// for dealing with codemirror
IvyCodeMirrorService.reopen({
dom: service('dom'),
modes: function() {
return MODES;
},
lint: function() {
return lint(...arguments);
},
getEditor: function(element) {
return get(this, 'dom').element('textarea + div', element).CodeMirror;
},
});
}

export default {
Expand Down
5 changes: 4 additions & 1 deletion ui-v2/app/styles/components/code-editor.scss
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
@import './code-editor/index';
// yet to make into placeholder
// yet to pull the CodeMirror skin into the placeholder
.code-editor {
@extend %code-editor;
}
186 changes: 2 additions & 184 deletions ui-v2/app/styles/components/code-editor/index.scss
Original file line number Diff line number Diff line change
@@ -1,184 +1,2 @@
$syntax-light-grey: #dde3e7;
$syntax-light-gray: #a4a4a4;
$syntax-light-grey-blue: #6c7b81;
$syntax-dark-grey: #788290;
$syntax-faded-gray: #eaeaea;
// Product colors
$syntax-atlas: #127eff;
$syntax-vagrant: #2f88f7;
$syntax-consul: #69499a;
$syntax-terraform: #822ff7;
$syntax-serf: #dd4e58;
$syntax-packer: #1ddba3;

// Our colors
$syntax-gray: lighten($ui-black, 89%);
$syntax-red: #ff3d3d;
$syntax-green: #39b54a;
$syntax-dark-gray: #535f73;

$syntax-gutter-grey: #2a2f36;
$syntax-yellow: $ui-yellow-500;
.CodeMirror {
max-width: 1150px;
min-height: 300px;
height: auto;
/* adds some space at the bottom of the editor for when a horizonal-scroll has appeared */
padding-bottom: 20px;
}
.CodeMirror-scroll {
overflow-x: hidden !important;
}
.CodeMirror-lint-tooltip {
background-color: #f9f9fa;
border: 1px solid $syntax-light-gray;
border-radius: 0;
color: lighten($ui-black, 13%);
font-family: $typo-family-mono;
font-size: 13px;
padding: 7px 8px 9px;
}

.cm-s-hashi {
&.CodeMirror {
width: 100%;
background-color: $ui-black !important;
color: #cfd2d1 !important;
border: none;
font-family: $typo-family-mono;
-webkit-font-smoothing: auto;
line-height: 1.4;
}

.CodeMirror-gutters {
color: $syntax-dark-grey;
background-color: $syntax-gutter-grey;
border: none;
}

.CodeMirror-cursor {
border-left: solid thin #f8f8f0;
}

.CodeMirror-linenumber {
color: #6d8a88;
}

&.CodeMirror-focused div.CodeMirror-selected {
background: rgb(33, 66, 131);
}

.CodeMirror-line::selection,
.CodeMirror-line > span::selection,
.CodeMirror-line > span > span::selection {
background: rgb(33, 66, 131);
}

.CodeMirror-line::-moz-selection,
.CodeMirror-line > span::-moz-selection,
.CodeMirror-line > span > span::-moz-selection {
background: rgba(255, 255, 255, 0.1);
}

span.cm-comment {
color: $syntax-light-grey;
}

span.cm-string,
span.cm-string-2 {
color: $syntax-packer;
}

span.cm-number {
color: $syntax-serf;
}

span.cm-variable {
color: lighten($syntax-consul, 20%);
}

span.cm-variable-2 {
color: lighten($syntax-consul, 20%);
}

span.cm-def {
color: $syntax-packer;
}

span.cm-operator {
color: $syntax-gray;
}
span.cm-keyword {
color: $syntax-yellow;
}

span.cm-atom {
color: $syntax-serf;
}

span.cm-meta {
color: $syntax-packer;
}

span.cm-tag {
color: $syntax-packer;
}

span.cm-attribute {
color: #9fca56;
}

span.cm-qualifier {
color: #9fca56;
}

span.cm-property {
color: lighten($syntax-consul, 20%);
}

span.cm-variable-3 {
color: #9fca56;
}

span.cm-builtin {
color: #9fca56;
}

.CodeMirror-activeline-background {
background: #101213;
}

.CodeMirror-matchingbracket {
text-decoration: underline;
color: $ui-white !important;
}
}

.readonly-codemirror {
.CodeMirror-cursors {
display: none;
}

.cm-s-hashi {
span {
color: $syntax-light-grey;
}

span.cm-string,
span.cm-string-2 {
color: $syntax-faded-gray;
}

span.cm-number {
color: lighten($syntax-dark-gray, 30%);
}

span.cm-property {
color: $ui-white;
}

span.cm-variable-2 {
color: $syntax-light-grey-blue;
}
}
}
@import './skin';
@import './layout';
31 changes: 31 additions & 0 deletions ui-v2/app/styles/components/code-editor/layout.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
%code-editor {
display: block;
border: 10px;
overflow: hidden;
position: relative;
}
%code-editor .ember-power-select-trigger {
@extend %code-editor-syntax-select;
}
%code-editor-syntax-select {
width: 200px;
float: right;
z-index: 1;
}
%code-editor-syntax-select {
margin-top: 1px;
border: 0;
background-color: $ui-black;
color: $ui-white;
border-left: 1px solid;
border-radius: 0;
}
%code-editor::after {
position: absolute;
bottom: 0px;
width: 100%;
height: 25px;
background-color: black;
content: '';
display: block;
}
Loading