Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow "disable_host_node_id": false to work on Linux as non-root #4926

Conversation

pierresouchay
Copy link
Contributor

Bump shirou/gopsutil to include shirou/gopsutil#603

This will allow to have consistent node-id even when machine is reinstalled
when using "disable_host_node_id": false

It will fix #4914

Bump `shirou/gopsutil` to include shirou/gopsutil#603

This will allow to have consistent node-id even when machine is reinstalled
when using `"disable_host_node_id": false`

It will fix hashicorp#4914 and allow having
the same node-id even when reinstalling a node from scratch. However,
it is only compatible with a single OS (installing to Windows will change
the node-id, but it seems acceptable).
@pierresouchay pierresouchay force-pushed the disable_host_node_id_false_works_on_linux branch from b8a9a72 to ebecce3 Compare November 8, 2018 18:52
@pierresouchay
Copy link
Contributor Author

@pearkes Can someone have a look, it is a fairly trivial change and it has been merged upstream in the library. It has very few consequences as well: only people opting for disable_host_node_id: false may be impacted (and basically, only when they do a full re-install by deleting node-id file)

It will ease re-installing nodes quickly (for instance for frequent re-install) on bare metal installations as the ID will be kept the same way and will not depend of boot time only.

Note that the feature was already working for the people running consul as root, but only for those, not it will have a predictable node-id even when not run as root (as long as the OS is linux and running systemd however, otherwise it fallbacks nicely on bootid). See shirou/gopsutil#603 if you need more info.

Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sensible to me.

@mkeeler mkeeler added this to the 1.4.1 milestone Jan 8, 2019
@mkeeler mkeeler merged commit 1618d79 into hashicorp:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disable_host_node_id": false does not work as advertised on Linux
2 participants