Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: use ServiceTags to generate cache key hash #4987

Merged
merged 7 commits into from
Jan 7, 2019

Conversation

banks
Copy link
Member

@banks banks commented Nov 22, 2018

This is minor updates on top of the great contribution by @goushicui in #4916.

It fixes the fact that we internally use ServiceTags now instead of ServiceTag.

In addition it cleans up internal usages to be more consistent and ready to deprecate the singular version as soon as we don't need backwards compatibility.

We actually still did use the singular version in one place (DNS) which made things a little more confusing. This cleans that up too.

@banks banks requested a review from a team November 22, 2018 14:12
@banks banks added this to the 1.4.1 milestone Nov 22, 2018
@pearkes pearkes requested a review from mkeeler January 7, 2019 17:42
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@banks banks merged commit b29bc90 into master Jan 7, 2019
@banks banks deleted the service-tags-cache-fix branch January 7, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants