Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix incorrect body of TestACLEndpoint_PolicyBatchRead #5370

Merged
merged 1 commit into from
Feb 22, 2019
Merged

fix incorrect body of TestACLEndpoint_PolicyBatchRead #5370

merged 1 commit into from
Feb 22, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Feb 21, 2019

Lifted from PR #5307 as it was an unrelated drive-by fix on that PR anyway.

s/token/policy/

@rboyer
fix incorrect body of TestACLEndpoint_PolicyBatchRead
db76a67 
Lifted from PR #5307 as it was an unrelated drive-by fix on that PR anyway.

s/token/policy/
@rboyer rboyer requested a review from mkeeler February 21, 2019 21:50
mkeeler
mkeeler approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a second I was thinking that I fixed this. Then I realized that you actually pulled from the PR where I fixed it but we can't merge yet.

@rboyer rboyer merged commit c2a30c5 into master Feb 22, 2019
@rboyer rboyer deleted the fix-acl-policy-test branch February 22, 2019 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rboyer @mkeeler