Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Connect with Envoy Guide #5505

Merged
merged 3 commits into from
Mar 26, 2019
Merged

[docs] Connect with Envoy Guide #5505

merged 3 commits into from
Mar 26, 2019

Conversation

kaitlincart
Copy link
Contributor

@kaitlincart kaitlincart commented Mar 18, 2019

Minimal updates, mainly cleaned up the intro to be concise.

  • Updated language from "Consul agent" to "Consul server"
  • Now there is only one production call out at the beginning.

@kaitlincart kaitlincart added the type/docs Documentation needs to be created/updated/clarified label Mar 18, 2019
@kaitlincart kaitlincart requested review from a team March 18, 2019 19:54
Copy link
Collaborator

@judithpatudith judithpatudith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Two optional nitpicks

website/source/docs/guides/connect-envoy.md Outdated Show resolved Hide resolved
website/source/docs/guides/connect-envoy.md Outdated Show resolved Hide resolved
judithpatudith and others added 2 commits March 25, 2019 09:27
Co-Authored-By: kaitlincarter-hc <43049322+kaitlincarter-hc@users.noreply.github.com>
Co-Authored-By: kaitlincarter-hc <43049322+kaitlincarter-hc@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants