Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove old UI #5643

Merged
merged 6 commits into from
Apr 12, 2019
Merged

Remove old UI #5643

merged 6 commits into from
Apr 12, 2019

Conversation

freddygv
Copy link
Contributor

This PR deletes the legacy UI, the option to use it, and associated build processes.

@freddygv freddygv requested review from mkeeler and johncowen April 10, 2019 21:19
@freddygv freddygv added this to the 1.5.0 milestone Apr 10, 2019
mkeeler
mkeeler requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally we are doing this! Just the one request now that we don't have to ride both uis in 1 static assets file.

agent/http.go Outdated Show resolved Hide resolved
mkeeler
mkeeler approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freddygv freddygv merged commit b2c1255 into master Apr 12, 2019
@freddygv freddygv deleted the remove-old-ui branch April 12, 2019 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

@johncowen johncowen Awaiting requested review from johncowen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@freddygv @mkeeler