ui: Ensure room for non-hidden scrollbars #5802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5720 we started to add some minor updates to our overall design look and feel, but in tracing designs we omitted leaving room for a scrollbar to the right hand side of our tabular rows. This reverts https://github.com/hashicorp/consul/pull/5720/files#diff-ee23af43927655ef31fe14838b182eccR17
On macOS generally users have these hidden but on other platforms and browsers these are visible and this can obstruct the 'action buttons' if we don't allow room for them.
Before:
After:
@opihana as a reminder, could we add permanent scrollbars to the designs, it will probably help us avoid mistakenly doing this again! (And/or, I think we discussed possibly tweaking the look and feel of these to take this into account?)