Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinates: allow configuring the update rate #5874

Closed

Conversation

ShimmerGlass
Copy link
Contributor

Allow to tune the coordinate update rate to reduce the load on the
servers for large datacenters.

@ShimmerGlass ShimmerGlass force-pushed the coordinate-rate-config branch from 1cf8714 to 319a5b8 Compare May 23, 2019 08:49
Allow to tune the coordinate update rate to reduce the load on the
servers for large datacenters.
@ShimmerGlass ShimmerGlass force-pushed the coordinate-rate-config branch from 319a5b8 to 77f798b Compare May 27, 2019 14:37
Copy link
Contributor

@pierresouchay pierresouchay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aestek this PR is weird (a bit empty)

-- EDITED -- sorry, I read badly the review, sound good to me

@slackpad
Copy link
Contributor

slackpad commented Jun 3, 2019

This is auto scaled based on the size of the cluster over in https://github.com/hashicorp/consul/blob/master/agent/agent.go#L1710 and batched on the server in https://github.com/hashicorp/consul/blob/master/agent/consul/coordinate_endpoint.go#L55-L153, so we tried hard to not need to tune this :-) Were you seeing a pathological heavy write case from coordinates?

@pierresouchay
Copy link
Contributor

@slackpad We are trying to limit as much the writes on our large clusters (6k+ nodes) since the leader has much to do and using 100% of CPU sometimes for long duration, we we are trying to tune not used features (such as coordinates we don't really use for now)

@slackpad
Copy link
Contributor

slackpad commented Jun 3, 2019

I see. I think you can just turn off coordinates if you aren't using them:

https://github.com/hashicorp/consul/blob/master/agent/config/config.go#L198

@pierresouchay
Copy link
Contributor

pierresouchay commented Jun 3, 2019

I see. I think you can just turn off coordinates if you aren't using them:

https://github.com/hashicorp/consul/blob/master/agent/config/config.go#L198

@slackpad Yes, you're might be right, it might be simpler

@Aestek we might abandon this one in that case

@pierresouchay
Copy link
Contributor

@slackpad this one is probably not a big deal, we can live without it especially with DisableCoordinates, but #5873 might be interesting to reduce a bit the load on leader server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants