Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Notify to avoid panic in newServer retry #6200

Merged
merged 1 commit into from
Jul 23, 2019
Merged

Restore Notify to avoid panic in newServer retry #6200

merged 1 commit into from
Jul 23, 2019

Conversation

freddygv
Copy link
Contributor

Addresses panic seen in CI:
https://circleci.com/gh/hashicorp/consul/55476#tests/containers/1

NotifyListen() can be called twice if we retry since the Config is being modified directly.

@freddygv freddygv requested a review from mkeeler July 23, 2019 20:11
mkeeler
mkeeler approved these changes Jul 23, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@freddygv freddygv merged commit d86efb8 into master Jul 23, 2019
@freddygv freddygv deleted the bugfix/testserver-retry branch July 23, 2019 20:33
@freddygv freddygv mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkeeler mkeeler mkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@freddygv @mkeeler