ui: HTTPAdapter - Move Tests #6281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregone
approved these changes
Aug 6, 2019
Merged
johncowen
added a commit
that referenced
this pull request
Aug 23, 2019
- Moves `respondFor` integration tests from adapter to serializer - Rename all the tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #5637 all API/data response re-shaping happens in serializers, in our
respondFor...methods.This PR basically covers this: (see #5637)
Here we move the tests into the correct folders, and slightly alter the name of the tests.
Please note this PR is being merged down onto #5637, not
masteror evenui-staging(our 'next' branch)