Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document how envoy escape hatches work with the discovery chain #6350

Merged
merged 7 commits into from
Aug 21, 2019
Merged

docs: document how envoy escape hatches work with the discovery chain #6350

merged 7 commits into from
Aug 21, 2019

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Aug 19, 2019

  • Bootstrap escape hatches are OK.
  • Public listener/cluster escape hatches are OK.
  • Upstream listener/cluster escape hatches are not supported.

If an unsupported escape hatch is configured and the discovery chain is
activated log a warning and act like it was not configured.

Fixes #6160

@rboyer
docs: document how envoy escape hatches work with the discovery chain
ba69621 
- Bootstrap escape hatches are OK.
- Public listener/cluster escape hatches are OK.
- Upstream listener/cluster escape hatches are not supported.

If an unsupported escape hatch is configured and the discovery chain is
activated log a warning and act like it was not configured.

Fixes #6160
@rboyer rboyer added type/docs Documentation needs to be created/updated/clarified theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies labels Aug 19, 2019
@rboyer rboyer added this to the 1.6.0-final milestone Aug 19, 2019
@rboyer rboyer requested review from a team August 19, 2019 21:06
@rboyer rboyer self-assigned this Aug 19, 2019
banks
banks approved these changes Aug 20, 2019
View reviewed changes
Copy link
Member

@banks banks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall content LGTM. One minor edit suggested. There may be some slightly simpler wordings we can find for the notes here - I defer to education team on that for now!

website/source/docs/connect/proxies/envoy.md Outdated Show resolved Hide resolved
mkeeler
mkeeler approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@mkeeler mkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rboyer rboyer requested a review from judithpatudith August 21, 2019 18:32
judithpatudith
judithpatudith approved these changes Aug 21, 2019
View reviewed changes
Copy link
Collaborator

@judithpatudith judithpatudith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I've suggested a couple of changes here and in Slack, but am going to give it a checkmark for when those get done

website/source/docs/connect/proxies/envoy.md Outdated Show resolved Hide resolved
website/source/docs/connect/proxies/envoy.md Outdated Show resolved Hide resolved
website/source/docs/connect/proxies/envoy.md Outdated Show resolved Hide resolved
website/source/docs/connect/proxies/envoy.md Show resolved Hide resolved
@rboyer rboyer merged commit 7a6facc into release/1-6 Aug 21, 2019
@rboyer rboyer deleted the document-escape-hatches-and-discovery-chain branch August 21, 2019 20:10
@rboyer rboyer mentioned this pull request Aug 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@judithpatudith judithpatudith judithpatudith approved these changes

@mkeeler mkeeler mkeeler approved these changes

@banks banks banks approved these changes

Assignees

@rboyer rboyer

Labels
theme/connect Anything related to Consul Connect, Service Mesh, Side Car Proxies type/docs Documentation needs to be created/updated/clarified
Projects
None yet
Milestone
1.6.0-final
Development

Successfully merging this pull request may close these issues.
4 participants
@rboyer @banks @mkeeler @judithpatudith